Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip reading unused columns #133

Merged
merged 3 commits into from
Oct 24, 2024
Merged

skip reading unused columns #133

merged 3 commits into from
Oct 24, 2024

Conversation

richox
Copy link
Contributor

@richox richox commented Oct 23, 2024

closes #132 .

@richox richox mentioned this pull request Oct 23, 2024
Open
waynexia
waynexia approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL @WenyXu

@waynexia
Copy link
Collaborator

Thanks for reporting and fixing this issue @richox ❤️

Xuanwo
Xuanwo approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @richox for fixing this, and thank you @waynexia for the review.

The only thing left is fixing our CI.

@richox richox force-pushed the dev-skip-unused-cols branch from be3c0aa to 11c881d Compare October 24, 2024 02:46
@richox richox force-pushed the dev-skip-unused-cols branch from 11c881d to 15ecd4d Compare October 24, 2024 02:48
WenyXu
WenyXu approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@WenyXu
Copy link
Collaborator

WenyXu commented Oct 24, 2024

The coverage test is failed😞

@richox
Copy link
Contributor Author

richox commented Oct 24, 2024

The coverage test is failed😞

fixed, we need to also read all children columns of nested types.

@WenyXu WenyXu merged commit 883c892 into datafusion-contrib:main Oct 24, 2024
13 checks passed
@WenyXu
Copy link
Collaborator

WenyXu commented Oct 24, 2024

The coverage test is failed😞

fixed, we need to also read all children columns of nested types.

Thanks ❤️ @richox

waynexia pushed a commit that referenced this pull request Oct 24, 2024
@richox
skip reading unused columns (#133)
b15df36 
* skip reading unused columns

* fix lint

* supports complex data types

---------

Co-authored-by: zhangli20 <zhangli20@kuaishou.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@waynexia waynexia waynexia approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip reading unused columns in stripes
4 participants
@richox @waynexia @WenyXu @Xuanwo