Skip to content

Commit

Permalink
[ALL TESTS PASS] Removing duplicate adding of B activations when we h…
Browse files Browse the repository at this point in the history
…ave reached the last A.
  • Loading branch information
SamuelAppleby committed Aug 15, 2023
1 parent ec329a2 commit bffbe75
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/knobab/mining/bolt2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -312,12 +312,6 @@ Bolt2Branching(const KnowledgeBase &kb, bool only_precise_temporal_patterns,
else {
not_a_activated_and_not_b_activated += (b_beginend.first == b_beginend.second)
? (ntraces - a_trace_id - 1) : (b_trace_id - a_trace_id - 1);

//TODO Here be dragons
if((b_beginend.first != b_beginend.second) && (branch == branch_type::LEFT)) {
TRACE_SET_ADD(data.r_activation_traces.second, b_trace_id);
TRACE_SET_ADD(data.p_activation_traces.second, b_trace_id);
}
}

continue;
Expand Down

0 comments on commit bffbe75

Please sign in to comment.