Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per plane processing #161

Merged
merged 27 commits into from
Sep 5, 2023
Merged

Per plane processing #161

merged 27 commits into from
Sep 5, 2023

Conversation

ttngu207
Copy link
Contributor

@ttngu207 ttngu207 commented Sep 5, 2023

No description provided.

Thinh Nguyen and others added 27 commits August 16, 2023 18:32
support multiplane processing with CaImAn - per-plane basis
5d71dab
update pipeline to support per-plane processing with caiman
53a75b8
at Processing - generate new PerPlaneProcessingTask or confirm all Pe…
34f2351 
…rPlaneProcessing have completed
Update setup.py
d471a04
bugfix
23e6527
minor fix
187522b
@kushalbakshi
Update attribute channel=' ' -> channel=null
02e87f0
@kushalbakshi
Update aggr function with .proj()
54dbf3a
@kushalbakshi
Update key_source for Processing
bfc1125
update caiman results ingestion - use latest caiman loader
b7c9e05
Update version.py
a0bb444
@kushalbakshi
Revert Processing ker_source + fix output_dir error
b2961f6
@kushalbakshi
Update key_source logic for Processing
6d03f94
@kushalbakshi
Fix for str AttributeError
38021f3
@kushalbakshi
Fix TypeError for 'str' and 'str'
e6d4c5b
@kushalbakshi
Debug mkdir AttributeError
16d4573
@kushalbakshi
Update caiman_loader keys for motion correction
3cb8b70
@kushalbakshi
Remove mask classification extraction from caiman loader
c12e7bb
@kushalbakshi
Merge branch 'per-plane-processing' of https://github.com/ttngu207/el…
07de08b 
…ement-calcium-imaging into per-plane-processing
@kushalbakshi
Add exception to debug summary images
a499fed
@kushalbakshi
Refine summary image loading
9322f77
@kushalbakshi
Internal variable fkey -> field_key
a57a024
@kushalbakshi
Append to summary image list
a645be4
fix incorrect shape in summary images retrieval
bf48a58
@kushalbakshi
Manually merge changes from Thinh's branch
342b86f
@kushalbakshi @ttngu207
Update element_calcium_imaging/imaging_no_curation.py
e7320b3 
Co-authored-by: Thinh Nguyen <thinh@datajoint.com>
@ttngu207
Merge pull request #2 from kushalbakshi/per-plane-processing
87b180f
kushalbakshi
kushalbakshi approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@kushalbakshi kushalbakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We will need to update the CHANGELOG when merging to datajoint/main

@kushalbakshi kushalbakshi merged commit 40ac3c2 into datajoint:caiman_per_plane_processing Sep 5, 2023
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalbakshi kushalbakshi kushalbakshi approved these changes

@sidhulyalkar sidhulyalkar Awaiting requested review from sidhulyalkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttngu207 @kushalbakshi