Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facemap Pose Estimation Inference #24

Merged
merged 185 commits into from
Nov 15, 2023

Conversation

sidhulyalkar
Copy link
Collaborator

  • Add facial_pose_model.py. Contains new facemap_model_schema with classes BodyPart, FacemapModel, FacemapPoseEstimationTask, and FacemapPoseEstimation.
  • Explanatory Jupyter notebook not included for now. (Using LuLab data, and local testing pipeline). Includes functions ingest_model, and generate_pose_estimation_task, which insert into the FacemapModel, FacemapPoseEstimationTask, and fbe.VideoRecording tables.

element_facemap/facemap_train.py Outdated Show resolved Hide resolved
element_facemap/facemap_train.py Outdated Show resolved Hide resolved
element_facemap/facemap_train.py Outdated Show resolved Hide resolved
element_facemap/facemap_train.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kushalbakshi kushalbakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small consideration before merging. @ttngu207, do you agree that the table should be renamed here? Facemap's documentation uses keypoints and body parts interchangeably in their tutorials.


# ----------------------------- Table declarations ----------------------
@schema
class BodyPart(dj.Lookup):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this table better identified as KeyPoints?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree but then I believe Facemap itself still refers to those as bodyparts, right?
The results are orofacial features, calling it body parts seems wrong. But if this is the terminology used in facemap, we should stick to the same term.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agreed, Facemap incorrectly uses the term 'BodyParts' to define their keypoints, but we should stick with their convention.

model_description='' : varchar(1000) # optional model description
"""

class BodyPart(dj.Part):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table could also be renamed KeyPoints if the Lookup table above is renamed


# ----------------------------- Table declarations ----------------------
@schema
class BodyPart(dj.Lookup):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree but then I believe Facemap itself still refers to those as bodyparts, right?
The results are orofacial features, calling it body parts seems wrong. But if this is the terminology used in facemap, we should stick to the same term.

@ttngu207 ttngu207 merged commit 2be11ec into datajoint:staging Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants