-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move versioneer configuration from setup.cfg to pyproject.toml #256
Conversation
versioneer became a bit too obnoxious in reporting its success and fail stories to the user in stdout which we rely on using as a result of an inquiry to setup.py: ❯ python setup.py --name 2>/dev/null Failed to load config from /home/yoh/proj/datalad/datalad-container/pyproject.toml: 'versioneer' Try to load it from setup.cfg datalad_container ❯ echo $? 0 to workaround -- just moving its configuration to its preferred location - pyproject.toml and it starts to behave a bit better
Code Climate has analyzed commit 6e560d7 and detected 0 issues on this pull request. View more on Code Climate. |
wow -- quite wild side-effects
and I guess it got there since there is no |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 24 24
Lines 1133 1133
=======================================
Hits 1073 1073
Misses 60 60 ☔ View full report in Codecov by Sentry. |
ha, ok, no chicken/egg then, all good. Let's see if that resolves our release issues! |
versioneer became a bit too obnoxious in reporting its success and fail stories to the user in stdout which we rely on using as a result of an inquiry to setup.py:
to workaround -- just moving its configuration to its preferred location - pyproject.toml and it starts to behave a bit better