Hardcode the name of the package in release action to avoid needing setuptools and invocation of setup.py #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etuptools and invocation of setup.py Per datalad#254 (comment) Closes datalad#254
|
Code Climate has analyzed commit f551c13 and detected 0 issues on this pull request. View more on Code Climate. |
jwodder
approved these changes
Jan 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 24 24
Lines 1134 1134
=======================================
Hits 1074 1074
Misses 60 60 ☔ View full report in Codecov by Sentry. |
|
dang, how could I forget to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #254 (comment)
Closes #254
no rush for this IMHO so not marking for release