Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetaladExampleDatasetExtractor accessors to properties? #382

Open
mih opened this issue Jul 19, 2023 · 0 comments
Open

MetaladExampleDatasetExtractor accessors to properties? #382

mih opened this issue Jul 19, 2023 · 0 comments
Milestone
Metalad-Improveme...

Comments

@mih
Copy link
Member

mih commented Jul 19, 2023

I am following http://docs.datalad.org/projects/metalad/en/latest/user_guide/writing-extractors.html to implement my first extractor. I got the impression that

  • get_id()
  • get_version()
  • get_data_output_category()

could/should be properties, rather than methods (ie., get the @property decorator).

Just wanted to leave a note on that observation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Metalad-Improvement Release
Development

No branches or pull requests
2 participants
@mih @christian-monch