-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the situation of installing the project without a tag #334
Comments
One option for handling this is to specify a |
can we just describe in our deployment documentation that need to have a tag or use a proper export/release on pypi? |
I can, but I feel that doing this make the setup process less intuitive and making our project seems less polished. We can consider adding this information as a "footnote" in the documentation, without interfering with the flow of the setup instruction. I think having a default tag as recommended by @jwodder is a better way to go. After all, we can't really ensure, if my limited understanding of @yarikoptic I am not aware that we currently have any release for DL-Registry on pypi. |
|
I filed #336 to follow up with this matter.
Though I don't like to see anyone encounter an error while installing the project, I see your point. Consistency does have its cost, and this is a good occasion to pay for it. I have made some addition to |
versioningit
, the versioning system, requires at one tag in the repo to work. If a new user trying out DL-Registry by forking it on GitHub without copying any tag, he/she may experience an error in setting up the project through the fork. Note about the handling of such a situation in the documentation or set up automatic version through another mechanism (such as automatic versioning throughpoetry version
once #329 is complete).The text was updated successfully, but these errors were encountered: