Add tag prerequisite for building DL-Registry package #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 52 52
Lines 2518 2518
=======================================
Hits 2485 2485
Misses 33 33 ☔ View full report in Codecov by Sentry. |
yarikoptic
reviewed
Mar 20, 2024
| of [the Datalad-Registry repository](https://github.com/datalad/datalad-registry), you | ||
| may need to | ||
| add [the Datalad-Registry repository](https://github.com/datalad/datalad-registry) as | ||
| a remote to your clone and fetch all the tags from it.) |
There was a problem hiding this comment.
IMHO too many instances of the same [the Datalad-Registry repository] hyperlink - just making it too verbose etc. But I would not sweat over it now. Let's proceed.
There was a problem hiding this comment.
Indeed so. Verbosity was one concern I had when putting up this PR. #340 corrects this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the prerequisite of requiring tags from the the Datalad-Registry repository to build the DL-Registry package to
README.md. It closes #334.