Skip to content

Commit

Permalink
feat: support extras umap with Python 3.12
Browse files Browse the repository at this point in the history
#209 introduced support for Python 3.12 with
extras umap not being supported. However, there is in reality nothing preventing umap
from being supported.

The missing support for 3.12 by `umap-learn` was based on a false premise that a new version
of the library needs to be released in order to add support for Python 3.12.
  • Loading branch information
mbelak-dtml committed Mar 4, 2024
1 parent 82a8ef1 commit 8f63194
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ ipywidgets = ">=7.5, <9"
colorlover = "*"
scikit-learn = ">=0.22.1"
nbconvert = "^7.0.0" # Required for exporting to HTML
umap-learn = { version = "^0.5.4", optional = true, python = "<3.12"}
umap-learn = { version = "^0.5.4", optional = true }
# umap-learn dependes on numba. It is specified explicitly to install
# a newer version, since by default it installs an older version of numba,
# which also installs an older version of llmvlite, which is incompatible
Expand Down

0 comments on commit 8f63194

Please sign in to comment.