Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve report example #164

Merged
merged 3 commits into from
Oct 10, 2023
Merged

docs: improve report example #164

merged 3 commits into from
Oct 10, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

No description provided.

@mbelak-dtml mbelak-dtml requested a review from lukany October 4, 2023 13:28
@mbelak-dtml mbelak-dtml self-assigned this Oct 4, 2023
lukany
lukany previously approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I am having quite big difficulties to see the diff. I am not able to review this properly TBH.

@mbelak-dtml
Copy link
Collaborator Author

Approved but I am having quite big difficulties to see the diff. I am not able to review this properly TBH.

Hmm, that's the disadvantage of storing the notebooks in .ipynb. I can only suggest to review the result, since the diff is really hard to see. Maybe VSCode could help -- it can somehow show notebook diffs.

@mbelak-dtml mbelak-dtml requested a review from lukany October 10, 2023 09:18
@lukany
Copy link
Contributor

lukany commented Oct 10, 2023

Approved but I am having quite big difficulties to see the diff. I am not able to review this properly TBH.

Hmm, that's the disadvantage of storing the notebooks in .ipynb. I can only suggest to review the result, since the diff is really hard to see. Maybe VSCode could help -- it can somehow show notebook diffs.

Thanks for the tip! VSCode actually shows really nice diffs!

@lukany lukany added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 1669adf Oct 10, 2023
6 checks passed
@lukany lukany deleted the docs/improve-report-example branch October 10, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukany lukany lukany approved these changes

Assignees

@mbelak-dtml mbelak-dtml

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbelak-dtml @lukany