Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unnecessary publish workflow permissions #204

Merged
merged 1 commit into from
Feb 15, 2024
Merged

ci: remove unnecessary publish workflow permissions #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ jobs:
publish-python:
runs-on: ubuntu-22.04 # convco needs GLIBC_2.32 which is not in 20.04
environment: publish
# IMPORTANT: trusted publishing requires permission: id-token: write! Without it, the trusted publishing will not work!
# If the permission is the only one that is set, all other permissions are automatically set to none, which may cause permissions issues within the job.
permissions: write-all
# Trusted publishing requires permission: id-token: write
# contents: read to access the repository's contents is set by default,
# however when permissions are explicitly set, the default is overridden.
permissions:
id-token: write
contents: read
outputs:
new_version: ${{ steps.set-vars.outputs.new_version }}
steps:
Expand Down
Loading