feat!: add initial support for python 3.12 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbelak-dtml
force-pushed
the
feat/python-3.12
branch
4 times, most recently
from
89e87cb to
c74c522
Compare
|
Blocked by #211 -- the tests fail under Python 3.12 because |
mbelak-dtml
force-pushed
the
feat/python-3.12
branch
from
83cc6b1 to
ae513d2
Compare
NOTE: extras umap-learn is not supported in Python 3.12 since umap-learn does not currently support Python 3.12. BREAKING CHANGE: Support for Python 3.8 is dropped.
mbelak-dtml
force-pushed
the
feat/python-3.12
branch
from
ae513d2 to
a417218
Compare
Resolved |
lukany
approved these changes
Mar 4, 2024
mbelak-dtml
added a commit
that referenced
this pull request
Mar 4, 2024
#209 introduced support for Python 3.12 with extras umap not being supported. However, there is in reality nothing preventing umap from being supported. The missing support for 3.12 by `umap-learn` was based on a false premise that a new version of the library needs to be released in order to add support for Python 3.12.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: extras umap-learn is not supported in Python 3.12 since umap-learn does not currently support Python 3.12.
BREAKING CHANGE: Support for Python 3.8 is dropped.