Remove addtime default and add ability to compute kth distance #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two suggested changes:
addtime
augmentation as a default. The data that users input may already have a time channel, and this default behaviour is unexpected. Some existing examples may have to be altered.kth
, this enables us to find the kth closest neighbour rather than always returning the nearest neighbour. This is in addition to then_neighbors
parameter as the latter findsn
neighbours in the projected subspace, once the distance away from the subspace is taken into account, the ordering of the neighbors will change.