From 5af665bc3651a73315ea8996397437306bd58bb4 Mon Sep 17 00:00:00 2001 From: Cedrick Lunven Date: Sun, 23 Jun 2024 13:11:53 +0200 Subject: [PATCH] Increase default chunks to 100 and add comments --- .../astradb/AstraDBEmbeddingStore.java | 2 +- .../astradb/EmbeddingSearchRequestAstra.java | 21 ++++++++++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/AstraDBEmbeddingStore.java b/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/AstraDBEmbeddingStore.java index 9b9a2417dd..8bcc2d0018 100644 --- a/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/AstraDBEmbeddingStore.java +++ b/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/AstraDBEmbeddingStore.java @@ -84,7 +84,7 @@ public AstraDBEmbeddingStore(@NonNull Collection client) { * concurrent threads */ public AstraDBEmbeddingStore(@NonNull Collection client, int itemsPerChunk, int concurrentThreads) { - if (itemsPerChunk>20 || itemsPerChunk<1) { + if (itemsPerChunk>100 || itemsPerChunk<1) { throw new IllegalArgumentException("'itemsPerChunk' should be in between 1 and 20"); } if (concurrentThreads<1) { diff --git a/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/EmbeddingSearchRequestAstra.java b/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/EmbeddingSearchRequestAstra.java index f720d6c784..3c44c0ff3c 100644 --- a/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/EmbeddingSearchRequestAstra.java +++ b/langchain4j-astradb/src/main/java/dev/langchain4j/store/embedding/astradb/EmbeddingSearchRequestAstra.java @@ -4,11 +4,30 @@ import dev.langchain4j.store.embedding.EmbeddingSearchRequest; import dev.langchain4j.store.embedding.filter.Filter; - +/** + * This abstract class represents a search request for embeddings in AstraDB + * A user can provide a field 'vectorize' that will be converted as a embedding on the spot and use for search or insertion + */ public class EmbeddingSearchRequestAstra extends EmbeddingSearchRequest { + /** + * The field to vectorize + */ private final String vectorize; + /** + * Constructor leveraging default search request but with the vectorize options. + * @param queryEmbedding + * vector or left empty to use the vectorize field + * @param vectorize + * field to vectorize + * @param maxResults + * maximum number of results to return + * @param minScore + * minimum score to return + * @param filter + * filter to apply + */ public EmbeddingSearchRequestAstra(Embedding queryEmbedding, String vectorize, Integer maxResults, Double minScore, Filter filter) { super(queryEmbedding != null ? queryEmbedding : Embedding.from(new float[0]), maxResults, minScore, filter); this.vectorize = vectorize;