Removing proof mechanism environment variable #85
Conversation
Signed-off-by: Madia Wilder <mwilder@Madias-MBP.attlocal.net>
| @@ -34,21 +34,17 @@ export TEST_ARCHIVIST="https://app.rkvst.io" | |||
| export TEST_AUTHTOKEN_FILENAME=credentials/.auth_token | |||
| export TEST_NAMESPACE="unique label" | |||
| export TEST_VERBOSE=-v | |||
| export TEST_PROOF_MECHANISM="--proof-mechanism=SIMPLE_HASH" | |||
There was a problem hiding this comment.
The problem with removing altogether is that in about 2 months we'll have the Khipu replacement and will have to put it all back again. Especially given that testing the new stuff is important I think we should leave this
| Windows using Powershell - at the command prompt set values for environment variables: | ||
|
|
||
| ```bash | ||
| $Env:TEST_ARCHIVIST="https://app.rkvst.io" | ||
| $Env:TEST_AUTHTOKEN_FILENAME = '<path of token location>' | ||
| $Env:TEST_NAMESPACE = Get-Date -UFormat %s | ||
| $Env:TEST_VERBOSE = '-v' | ||
| $Env:TEST_PROOF_MECHANISM="--proof-mechanism=SIMPLE_HASH" |
There was a problem hiding this comment.
The problem with removing altogether is that in about 2 months we'll have the Khipu replacement and will have to put it all back again. Especially given that testing the new stuff is important I think we should leave this
| @@ -73,7 +69,7 @@ Events are created every execution of an example - currently no check is done if | |||
| All examples use a common set of arguments: | |||
|
|
|||
| ```bash | |||
| export AUTH="-u $TEST_ARCHIVIST -t $TEST_AUTHTOKEN_FILENAME $TEST_VERBOSE $TEST_PROOF_MECHANISM" | |||
There was a problem hiding this comment.
The problem with removing altogether is that in about 2 months we'll have the Khipu replacement and will have to put it all back again. Especially given that testing the new stuff is important I think we should leave this
| ``` | ||
|
|
||
| If TEST_VERBOSE is "-v" debugging output will appear when running the examples. Otherwise leave blank or undefined. | ||
|
|
||
| TEST_PROOF_MECHANISM should be "KHIPU" or "SIMPLE_HASH". If unspecified the default is "SIMPLE_HASH" |
There was a problem hiding this comment.
TEST_PROOF_MECHANISM should be "SIMPLE_HASH"
Yes, am aware that proof mechanism is valid and we have removed KHIPU.
Based on recent changes and talks, makes sense to remove the proof mechanism environment variable on the readme for samples since KHIPU is not an option and we are leaning towards most users on simple hash. Greater number of people using our samples "should" be on simple hash in theory. Removing decreases confusion and ran wipp sample w/out the environment variable and as expected it works.
Oh and removed the word "KHIPU" from the main repo readme also.