From 2909412af5c85cceff07090b46c9efd087c64499 Mon Sep 17 00:00:00 2001 From: Vanessa Stoiber <52395160+dvvanessastoiber@users.noreply.github.com> Date: Fri, 14 Oct 2022 09:06:37 +0200 Subject: [PATCH] Release 16.2.0 (#800) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * adding custom data to basic bar charts * fixing context selection bug * more bug fixes * Refactor multi selection adapter - Add optional `diffSubtypes` to `IMultiSelectionAdapter` - Remove `ReprovisynMultiSelectionAdapter` - Add generics to `MultiSelectionAdapter` - Comment functions of `MultiSelectionAdapter` * Replace `PromiseLike` with `Promise` + async/await See also https://masteringjs.io/tutorials/fundamentals/promise-resolve * Replace `() => IContext` with `IContext` Unecessary convoluted call * Remove `waitForIt` promise from selection adapter - Add and refactor return types `Promise` to `Promise` - Switch to async/await where possible - await `removeDynamicColumns` before `addDynamicColumns` -> previously it was not waited for the removal * Add unit tests for SelectionAdapter * adding parameters check on use effect * removing outdated todo * Update context inside selection adapter * fixing default params value * builds * fixing bar selection * making bar click removal work * code improvements * fixing uncontrolled error * removing zooming on bar charts * adding promise to fix typing * pr suggestions/cleanup * prepare next development version 15.0.1-SNAPSHOT * Added build-storybook to build script (#733) * Added build-storybook to build script * Add tdp_core/dist alias to the storybook webpack config * updated version of storybook (#736) Co-authored-by: Moritz Heckmann Co-authored-by: dvmoritzschoefl <77104411+dvmoritzschoefl@users.noreply.github.com> Co-authored-by: Moritz Heckmann * Fix eslint for AggregateTypeSelected Probably a missing type cast in PR https://github.com/datavisyn/tdp_core/pull/729 * Remove await `this.built` in `withoutTracking()` Waiting for `this.built` will never resolve/terminate and show an infite loading icon. Reason: `this.built` is created with `build()` in line 355 and it is only resolved after the `build()` call is complete. With the changes to the selection adapter the `this.selectionAdapter.selectionChanged` now returns a valid promise. Previously, `context.add()` did not return it's promise (see https://github.com/datavisyn/tdp_core/pull/725/commits/919cfb20fb747264b425bce7a0d8a0957d3ea5ef#diff-f0f07e4a6ac30a813315b152545245d4cf26830e01b701f3e82ff7b5c22363a7R18). Now, we are waiting until all dynamic columns are added. The circle closes when we add the columns which calls `withoutTracking()` which in-turn is waiting for the resolved `this.built` promise. As far as I can see, we always call `withoutTracking` on a built/resolved ranking view. In the other places (line 377 and 400) we have a dedicated `await this.built;` before triggering changes to dynamic columns. In my tests adding and removing columns via score and selection adapter worked as before. I also tested reloading the page and checked the result of the session. In all cases it looks the same as before. * use `useRef` instead of `useSyncedRef` * Add Storybook stories for custom buttons (#708) * create first storybook for button styles * add story for single button * change background * linting * fix background * add additional kind of buttons * typing * add functions for buttons into stories * started chaning source of button * finish Button storybook docu * linting problems * linting * styling of code * change style to UI * add comments * Added build-storybook to build script * Add tdp_core/dist alias to the storybook webpack config * added outline buttons, adjusted layout to not contain margin inside a story, added link to styleguide Co-authored-by: Michael Puehringer Co-authored-by: Moritz Heckmann * added cypress run script to package json (#738) Co-authored-by: Moritz Heckmann * Add exception handler middleware (#723) * Add exception handler middleware * Extract default logging config and set it on server startup Co-authored-by: dvtschachinger * address PR comments * Initial visyn_scripts integration * Update storybook script to storybook:build * adding description to axis labels (#744) * Add NODE_OPTIONS=--max_old_space_size=4096 to storybook scripts (#746) * Add NODE_OPTIONS=--max_old_space_size=4096 to storybook scripts * Update build script to include storybook:build * Update cache key * Fix `ARankingView` typings of `rebuild` and `reloadData` (#749) * prepare next dev version * Fixed return value of logout of ALB security store (#751) * Fix incorrect route for server buildInfo.json (#752) * Export initialize.ts for external Storybook instance (#753) * Migrated to new webpack5 visyn_scripts * Updated npm scripts * Moved entries from yo-rc to package.json * Fix SCSS warning for divide numbers using `/` (#758) Fix SCSS warning for divide numbers using / * Show selection indicator next to scroll bar in rankings (#756) Show LineUp selection indicator next to scroll bar * Prepare github changes * Update CODEOWNERS * Prepare github changes * Prepare github changes * Prepare github changes * Prepare github changes * Remove circleci * prepare next dev version * Set modal focus based on tour visiblity and replace Bootstrap jQuery modal with plain JS modal (#754) * Replace BS jQuery modal with plain JS modal https://github.com/Caleydo/tdp_bi_bioinfodb/issues/1371 * Refactor modal options * Replace deprecated `evt.keyCode` with `evt.key` * Set modal focus flag based on tour's visibility Also revert dialog constructor parameter to `backdrop` only again. * Resolve some dependency cycles * Upgrade to Font Awesome v6 (#732) * update to fontawesome v6 * added fontawesome scss file * add dist files * Fix icon position in sidepanel tab * Update dependency lineupjs@4.6.2 Co-authored-by: Moritz Heckmann Co-authored-by: Holger Stitz * Updated modal typings in dialogs.ts to return HTMLDivElement for body (#765) * Added tsconfig.json to package.json files to allow the prepack script to build via tsc * Moved phovea_registry to src/phovea_registry.ts * Removed phovea_registry.js from package.json files * Add package-lock.json * Update build.yml * Fix Error Where FormDialog Fails to Be Instantiated (#766) check if `.tdp-tour-step-count` exists * refactor: Avoid general aside styles caused by CLUE (#763) Refactor CLUE aside styles * Avoid general `