Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests working and passing again #687

Merged
merged 5 commits into from
Dec 30, 2023

Conversation

anarion80
Copy link
Contributor

What this PR does / why we need it:

This PR does a couple things:

  1. Updates all references to former master branch to current main branch - so that links and actions work again.

  2. Updates actions (checkout, setup-python, setup-node) to latest versions to get rid of warnings.

  3. Updates articulate/actions-markdownlint action to v1.1.0 which supports the version input <- this is still showing as a warning though, so not sure what's going on :(

  4. Fix linting and n8n role so that tests are passing.

Some references:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://github.blog/changelog/2023-07-17-github-actions-removal-of-node12-from-the-actions-runner/
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Which issue (if any) this PR fixes:

Fixes #

Any other useful info:

@davestephens davestephens merged commit 1595a56 into davestephens:main Dec 30, 2023
3 checks passed
@davestephens
Copy link
Owner

Awesome collection of changes, thank you 👍

@anarion80
Copy link
Contributor Author

Thanks, although since then Integration tests are failing again:

 ERROR! couldn't resolve module/action 'community.docker.docker_container'. This often indicates a misspelling, missing collection, or incorrect module path.
  
  The error appears to be in '/usr/local/lib/python3.11/site-packages/molecule_plugins/docker/playbooks/destroy.yml': line 15, column 7, but may
  be elsewhere in the file depending on the exact syntax problem.
  
  The offending line appears to be:
  
  
      - name: Destroy molecule instance(s)
        ^ here
  CRITICAL Ansible return code was 4, command was: ansible-playbook --inventory /github/home/.cache/molecule/bitwarden/default/inventory --skip-tags molecule-notest,notest /usr/local/lib/python3.11/site-packages/molecule_plugins/docker/playbooks/destroy.yml
WARNING  An error occurred during the test sequence action: 'destroy'. Cleaning up.

something with molecule, but I couldn't figure out what is going on yet :(

@davestephens
Copy link
Owner

I saw, I'm just upgrading some other deps then will take a look 👍

@anarion80 anarion80 deleted the upstream2 branch May 7, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants