Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in Dark Mode #6

Open
cormullion opened this issue Jul 15, 2024 · 3 comments
Open

Check in Dark Mode #6

cormullion opened this issue Jul 15, 2024 · 3 comments

Comments

@cormullion
Copy link

Looks pretty cool!

I suggest you have a quick look through the docs in Dark Mode - quite a few images need a background. since you’re using black ink a lot. 😀

@davibarreira
Copy link
Owner

@cormullion , what a pleasure to have you checking my package! Thanks a lot for the heads-up on the dark mode docs.

@davibarreira
Copy link
Owner

I've checked the docs for Gadfly. They actually leave without the white background. I was wondering whether it is a good idea to have the white background, cause it might lead people to think that such background is always present.
The black color is the default in SVG, so changing the color would make the docs more verbose.

I've added the white background to some plots, but I'm thinking of leaving as it is in the other stuff.
What do you think?

Just to be clear, every figure can have a white background by simply writing:

draw(plt, style="background-color:white")

@cormullion
Copy link
Author

People often ask "How do I make the background transparent?" and "How do I make the background white?", so including these instructions explicitly wouldn't be a bad thing... I think verbosity isn't a bad thing in documentation, particularly if if saves someone asking on Discourse :)

If you use colours with medium Luminance, you can draw diagrams that are readable on both black or white backgrounds:

Screenshot 2024-07-15 at 18 23 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants