Implement interface for gin #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebianchi
requested changes
Jun 2, 2023
There was a problem hiding this comment.
Hi @VishvaNavanjana! Thank you for the PR, I think that add gin-gonic to the repo would be awesome!
Can you add unit and integration tests? You can look at those made for other supported routers.
Comment on lines
+20
to
+31
| switch method { | ||
| case http.MethodGet: | ||
| return r.router.GET(path, gin.HandlerFunc(handler)) | ||
| case http.MethodPost: | ||
| return r.router.POST(path, gin.HandlerFunc(handler)) | ||
| case http.MethodPut: | ||
| return r.router.PUT(path, gin.HandlerFunc(handler)) | ||
| case http.MethodDelete: | ||
| return r.router.DELETE(path, gin.HandlerFunc(handler)) | ||
| default: | ||
| return r.router.Any(path, gin.HandlerFunc(handler)) | ||
| } |
There was a problem hiding this comment.
This switch/case can lead to unexpected behaviour (for example, if set PATCH method this will set Any methods, which are GET, POST, PUT, PATCH, HEAD, OPTIONS, DELETE, CONNECT, TRACE).
What do you think about replace it with the match method?
Something like:
Suggested change
| switch method { | |
| case http.MethodGet: | |
| return r.router.GET(path, gin.HandlerFunc(handler)) | |
| case http.MethodPost: | |
| return r.router.POST(path, gin.HandlerFunc(handler)) | |
| case http.MethodPut: | |
| return r.router.PUT(path, gin.HandlerFunc(handler)) | |
| case http.MethodDelete: | |
| return r.router.DELETE(path, gin.HandlerFunc(handler)) | |
| default: | |
| return r.router.Any(path, gin.HandlerFunc(handler)) | |
| } | |
| return r.router.Match([]string{method}, path, handler) |
| } | ||
|
|
||
| func (r ginRouter) TransformPathToOasPath(path string) string { | ||
| return path |
There was a problem hiding this comment.
Gin seems to support path params with colon, is it true? It should be converted to oas spec with this. Can you see an example usage in fiber support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.