-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve auth tests #275
Merged
Merged
Improve auth tests #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmyersdev
had a problem deploying
to
preview
February 24, 2024 03:44
— with
GitHub Actions
Failure
davidmyersdev
force-pushed
the
add-social-auth-tests
branch
from
February 24, 2024 04:09
8a58373
to
5e53e44
Compare
davidmyersdev
force-pushed
the
add-social-auth-tests
branch
from
February 24, 2024 19:20
5e53e44
to
0f66771
Compare
davidmyersdev
force-pushed
the
add-social-auth-tests
branch
from
February 24, 2024 19:35
0f66771
to
391b028
Compare
davidmyersdev
force-pushed
the
add-social-auth-tests
branch
from
February 24, 2024 19:47
391b028
to
81b4981
Compare
davidmyersdev
force-pushed
the
add-social-auth-tests
branch
from
February 24, 2024 19:51
81b4981
to
7a68efb
Compare
This prop was originally meant to help avoid issues related to components not reloading when the page changed. Since then, it has become a problem in other areas and leads to less predictable behavior.
Due to WebKit restrictions, auth requests need to be proxied through the same IP **and** port that the main page is served on.
These tests run against the emulator suite rather than as a healthcheck due to bot-prevention measures implemented by Google, etc. Ideally, it'd be nice to have a healthcheck that runs reliably against the production instance, but I'm not sure how I'd implement that at the moment.
davidmyersdev
force-pushed
the
add-social-auth-tests
branch
from
February 24, 2024 20:31
7a68efb
to
7331d1c
Compare
davidmyersdev
had a problem deploying
to
preview
February 24, 2024 21:07
— with
GitHub Actions
Failure
This was
linked to
issues
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#273