Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #299: Fix for "New" button redirect on assistant chat #302

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

3thanHead
Copy link
Contributor

pushRoute: (to: RouterLinkProps['to']) => {
const resolved = router.resolve(to)
if (isClient) {
// This will prevent components from reloading (the behavior of router.push).
window.history.pushState(window.history.state, '', resolved.fullPath)
}
},

Seems like useSoftNavigation is no longer necessary here. Instead of calling pushRoute on a watcher, we can redirect with Vue Router when chat begins. Removing this allows NuxtLink of "New" button to redirect correctly.

@3thanHead
Copy link
Contributor Author

build passes locally for me, but is failing during CI checks. Looking into this.

@3thanHead
Copy link
Contributor Author

I see issue now after syncing fork. Solving.

@davidmyersdev davidmyersdev merged commit d220112 into davidmyersdev:main Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants