Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant HTTP.start block #34

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Remove redundant HTTP.start block #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions lib/mfynab/money_forward.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,18 @@ def get_session_id(username:, password:)
def download_csv(session_id:, path:, months:)
month = Date.today
month -= month.day - 1 # First day of month
months.times do
date_string = month.strftime("%Y-%m")

Net::HTTP.start(base_url.host, use_ssl: true) do |http|
http.response_body_encoding = Encoding::SJIS

months.times do
date_string = month.strftime("%Y-%m")
logger.info("Downloading CSV for #{date_string}")

logger.info("Downloading CSV for #{date_string}")

# FIXME: I don't really need to save the CSV files to disk anymore.
# Maybe just return parsed CSV data?
File.open(File.join(path, "#{date_string}.csv"), "wb") do |file|
file << download_csv_string(date: month, session_id: session_id)
end

month = month.prev_month
# FIXME: I don't really need to save the CSV files to disk anymore.
# Maybe just return parsed CSV data?
File.open(File.join(path, "#{date_string}.csv"), "wb") do |file|
file << download_csv_string(date: month, session_id: session_id)
end

month = month.prev_month
end
end

Expand Down