Add missing dependencies in moveable and svelte-moveable packages #1115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When consuming the
svelte-movealbe
package in a pnpm monorepo,vite build
andvite dev
fails with error saying "Cannot find module framwork-utils". However, in an npm managed repo, builds are fine. This is because pnpm requires each package to correctly specify direct dependencies, where npm allow dependencies to be shared across packages.E.g.
In this case, A and B both directly depend on C. For npm, if A declares C as a dependency, but B does not, it is fine. For pnpm, both A and B has to declare C as a dependency.
Root Cause:
moveable
package directly depend onframework-utils
, but missing it as a dependency in its package.json file.svelte-moveable
package directly depend on@daybrush/utils
, but missing it as a dependency in its package.json file.Solution:
Adding missing dependencies in corresponding package.json files, under
dependencies
field because they are labeled asexternal
in therollup.config.js
file.