Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small developer improvements for Windows-based devs. #1364

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Small developer improvements for Windows-based devs. #1364

merged 2 commits into from
Sep 2, 2022

Conversation

ERYoung11
Copy link
Contributor

Description

Some small improvements to make the development cycle better on Windows.

  • requirements-dev.txt - pexpect doesn't work on Windows so I just put in a conditional to skip it on Windows. Also added sshtunnel since tests require it.
  • setup.py - downloading psycopg-binary >= 3.0.14 on Windows only because Windows won't work without the binary version
  • Some additions to DEVELOP.rst to give hints on how to do things on Windows and with VSCode debugging.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@amjith
Copy link
Member

amjith commented Sep 2, 2022

Thank you! It is nice to know that the code base gets utilized in Windows environment.

@amjith amjith merged commit f858c4d into dbcli:main Sep 2, 2022
@j-bennet
Copy link
Contributor

j-bennet commented Jul 28, 2023

@ERYoung11 We are now requiring a binary install in Windows, and I think it might be problematic sometimes:

#1413

Here, @dvarrazzo advised that depending on binary is not a good idea:

psycopg/psycopg#368 (comment)

You said that python install didn't work for you on Windows though. What was the problem?

Update: nevermind, the person actually had a source install of psycopg. Problem is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants