Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRRR Extent #564

Merged
merged 7 commits into from
Jul 17, 2023
Merged

HRRR Extent #564

merged 7 commits into from
Jul 17, 2023

Conversation

bbuzz31
Copy link
Collaborator

@bbuzz31 bbuzz31 commented Jul 12, 2023

Because of a quirk in the HRRR projection, a user requested bounding box could appear to be valid but actually be outside of the model domain.
This fixes the initial check to make sure the requested aoi is contained in HRRR domain.

UPDATE:
The code will give a warning if HRRR doesn't cover the requested AOI but continue processing.
It will also write delays (and continue processing if requested) even if they contain nans

Closes #562

@bbuzz31 bbuzz31 requested a review from jlmaurer July 12, 2023 00:10
This was referenced Jul 12, 2023
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me!

Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jlmaurer jlmaurer merged commit a14b068 into dbekaert:dev Jul 17, 2023
3 checks passed
@bbuzz31 bbuzz31 mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HRRR bounds issue [BUG]
2 participants