Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests to remove some downloading #565

Merged
merged 13 commits into from
Aug 11, 2023

Conversation

jlmaurer
Copy link
Collaborator

This PR focuses on streamlining unit tests to avoid downloading when possible

Description

  • removes downloads from test_datelist

Motivation and Context

  • repeated download failures make it hard to test

How Has This Been Tested?

  • updated tests pass locally

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] unit test update

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jlmaurer jlmaurer marked this pull request as ready for review August 6, 2023 00:58
@jlmaurer jlmaurer requested a review from bbuzz31 August 6, 2023 00:59
@jlmaurer
Copy link
Collaborator Author

jlmaurer commented Aug 6, 2023

@bbuzz31 can you take a quick look at the error message on this? This PR is passing locally and I ran the test independently and completes just fine.

@jlmaurer
Copy link
Collaborator Author

jlmaurer commented Aug 8, 2023

@bbuzz31 I think this can be merged!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can / should this yaml file be created on the fly like the other ones?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can/should it point to the global testing WM_DIR (RAiDER/test/weather_files)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will get skipped due to @pytest.mark.long? yes?
I think we'd prefer that not to happen, as the GUNW workflow will be cranking lots of products

@jlmaurer jlmaurer merged commit 097205f into dbekaert:dev Aug 11, 2023
3 checks passed
@jlmaurer jlmaurer deleted the elim_dloads_from_unittests branch October 3, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants