Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wm nans #567

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Allow wm nans #567

merged 3 commits into from
Jul 18, 2023

Conversation

bbuzz31
Copy link
Collaborator

@bbuzz31 bbuzz31 commented Jul 18, 2023

In #564 we decided to allow the code to proceed if there are nans in the delays (typically caused by a user specifying an AOI that exceed the weather model bounds).

Similarly, if the user requests a bounding box (or gnss stations) that are outside of CONUS but wants HRRR, there will be nans in the weather model itself.

So here we now allow the code to proceed if there are nans in the weather model.

@bbuzz31 bbuzz31 requested a review from jlmaurer July 18, 2023 19:52
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem like it should work. Did you run test runs with different models?

@jlmaurer jlmaurer merged commit ce59fcb into dbekaert:dev Jul 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants