Tests for new fillna #569
Merged
Tests for new fillna #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlmaurer
reviewed
Jul 20, 2023
tools/RAiDER/processWM.py
Outdated
| @@ -86,7 +86,7 @@ def prepareWeatherModel( | |||
| ) | |||
|
|
|||
| containment = weather_model.checkContainment(ll_bounds) | |||
| if not containment: | |||
| if not containment and not weather_model._Name.startswith('HRRR'): | |||
There was a problem hiding this comment.
Is there a reason why HRRR here and not other models?
There was a problem hiding this comment.
Well the other models are global, so I figured if something is outside there's a problem somewhere (like aoi specified incorrectly)
There was a problem hiding this comment.
That's a good point, but what if we or someone else introduces another regional model? would there be a way to be more general?
There was a problem hiding this comment.
I put the ~inverse for now (If it the weather model is GMAO ERA5/T or HRES and its not contained it will crash).
Maybe we could add an attribute to the weather model class like is_global but I don't see an easy way of doing it smartly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have all tests back up and working.
staged weather model files had to be updated and golden delay values had to be adjusted by (by less than a millimeter) in a few places to account for new interpolation scheme