Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0 -- orbits and stand-alone HyP3 job support #641

Merged
merged 40 commits into from
Apr 29, 2024
Merged

Conversation

jhkennedy
Copy link
Collaborator

No description provided.

@jhkennedy jhkennedy added the minor Bump the minor version number of this project label Apr 26, 2024
@jhkennedy jhkennedy requested a review from cmarshak April 26, 2024 21:30
cmarshak
cmarshak previously approved these changes Apr 26, 2024
Copy link
Collaborator

@cmarshak cmarshak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the throughput of the orbit credential fixes and am confident this will be a good stop cap until sentineleof is fixed more permanently.

Copy link
Collaborator Author

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmarshak what's going on with the tests?

CHANGELOG.md Outdated Show resolved Hide resolved
@jhkennedy jhkennedy dismissed cmarshak’s stale review April 26, 2024 21:34

tests failing; changelog needs updating

@jhkennedy jhkennedy mentioned this pull request Apr 26, 2024
1 task
@cmarshak
Copy link
Collaborator

I am mystified. The circleCI outputs are confusing, but they are related to the mocks of the hyp3 metadata e.g.

 def test_GUNW_hyp3_metadata_update_different_prefix(test_gunw_json_path, test_gunw_json_schema_path, tmp_path, mocker):
        """This test performs the GUNW entrypoint using a different input bucket/prefix than the output bucket/prefix.
        Only updates the json. Monkey patches the upload/download to/from s3 and the actual computation.
        """
        temp_json_path = tmp_path / 'temp.json'
        shutil.copy(test_gunw_json_path, temp_json_path)
    
        # We only need to make sure the json file is passed, the netcdf file name will not have
        # any impact on subsequent testing
        mocker.patch("RAiDER.aws.get_s3_file", side_effect=['foo.nc', temp_json_path])
        mocker.patch("RAiDER.aws.upload_file_to_s3")
        mocker.patch("RAiDER.aria.prepFromGUNW.main", return_value=['my_path_cfg', 'my_wavelength'])
        mocker.patch('RAiDER.aria.prepFromGUNW.check_hrrr_dataset_availablity_for_s1_azimuth_time_interpolation',
                     side_effect=[True])
        mocker.patch("RAiDER.aria.prepFromGUNW.check_weather_model_availability", return_value=True)
        mocker.patch("RAiDER.cli.raider.calcDelays", return_value=['file1', 'file2'])
        mocker.patch("RAiDER.aria.calcGUNW.tropo_gunw_slc")
    
        iargs = ['--weather-model', 'HRES',
                 '--bucket', 'myBucket',
                 '--bucket-prefix', 'myOutputPrefix',
                 '--input-bucket-prefix', 'myInputPrefix',]
>       calcDelaysGUNW(iargs)

But #640 succeeded - not sure. Maybe let's retry?

Adjust tests for png upload/download
@cmarshak
Copy link
Collaborator

So with your work on #642 fixed the test and this release, which is now ready to support the orbit issue AND ongoing work with submitting individual hyp3 job ids.

@jhkennedy
Copy link
Collaborator Author

@cmarshak correct. The Changelog just needs to be updated and this should be ready to go. Would be nice to get this out today, but I'm on baby duty today and tomorrow so won't be able to help

@jhkennedy jhkennedy merged commit c1ef3f1 into main Apr 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Bump the minor version number of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants