Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests for png upload/download #642

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Adjust tests for png upload/download #642

merged 1 commit into from
Apr 27, 2024

Conversation

jhkennedy
Copy link
Collaborator

Notably, the tests aren't run on a fork, which is why we see them failing in #641 but not in #640.

I'm not using a fork here.

@jhkennedy jhkennedy added bug Something isn't working bumpless Changes which do not require a version bump and do not need to be recorded in the changelog labels Apr 27, 2024
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything passed this time

@jlmaurer jlmaurer merged commit b0e483a into dev Apr 27, 2024
12 checks passed
@jhkennedy jhkennedy deleted the fix-tests branch April 28, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bumpless Changes which do not require a version bump and do not need to be recorded in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants