Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to get rid of extra files created when running tests #674

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

royagrace
Copy link
Contributor

Description

Added several pushd tmp_paths to the tests so that the tests would not create unneeded files or directories when running.

How Has This Been Tested?

Unit tests passed locally. The changes do not modify or affect any other tests or functionality in the program besides what they were intended for.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@royagrace
Copy link
Contributor Author

@jlmaurer

@royagrace
Copy link
Contributor Author

@jlmaurer

@jlmaurer jlmaurer self-requested a review July 28, 2024 19:22
Copy link
Collaborator

@jlmaurer jlmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@royagrace please format each of the files that were updated using ruff. See here

@jlmaurer jlmaurer merged commit 8cc9722 into dbekaert:dev Aug 5, 2024
7 of 8 checks passed
@garlic-os
Copy link
Contributor

It looks like test_GUNW.py::test_azimuth_timing_interp_against_center_time_interp is still producing files in the repo directory. These are the files it outputted for me:

  • GUNW_20210723-20210711_015000.yaml
  • HRRR_tropo_20210711T015024_ray.nc
  • HRRR_tropo_20210723T015024_ray.nc
  • orbits\S1B_OPER_AUX_POEORB_OPOD_20210812T111941_V20210722T225942_20210724T005942.EOF
  • test\gunw_azimuth_test_data\weather_files\HRRR_2021_07_11T01_50_24_timeInterp_33N_36N_120W_115W.nc
  • test\gunw_azimuth_test_data\weather_files\HRRR_2021_07_11T01_50_24_timeInterpAziGrid_33N_36N_120W_115W.nc
  • test\gunw_azimuth_test_data\weather_files\HRRR_2021_07_23T01_50_24_timeInterp_33N_36N_120W_115W.nc
  • test\gunw_azimuth_test_data\weather_files\HRRR_2021_07_23T01_50_24_timeInterpAziGrid_33N_36N_120W_115W.nc

I am on dev branch commit 077674f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants