Fix credentials tests #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parentheses in the asserts in test_envVars and test_updateTrue were being interpreted as a set(!), making them always evaluate to True. This was resulting in these tests passing when there was actually something wrong with them. - Asserts fixed to evaluate correctly - Tests fixed to pass fair and square even with the corrected assertions
…s/RAiDER into patch-credentials-tests
jlmaurer
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parentheses in the asserts in test_envVars and test_updateTrue were being interpreted as a set(!), making them always evaluate to True. This was resulting in these tests passing when there was actually something wrong with them.
Sorry for letting this slip in!
Type of change
Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.