Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to ignore numbers and acronyms #25

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

Cellane
Copy link
Contributor

@Cellane Cellane commented Feb 27, 2018

I tried my best to add options to disable treating numbers and acronyms as spelling errors, as requested in issue #24 and as required for a few projects of mine. Unfortunately, I am not very familiar with the Ruby world so I was not actually able to test that this works outside of local irb test, so I apologise in advance if I made any mistake 🙏 Hopefully it's at least a start, fingers crossed.

@orta
Copy link
Collaborator

orta commented Feb 27, 2018

Yeah, this should be fine

@orta orta merged commit 60daf72 into dbgrandi:master Feb 27, 2018
@Cellane
Copy link
Contributor Author

Cellane commented Feb 27, 2018

Thank you very much! Do you think this feature alone could result in a new version being published into RubyGems repository?

@orta
Copy link
Collaborator

orta commented Feb 27, 2018

Yeah, shipped as v2.0.6.

@Cellane
Copy link
Contributor Author

Cellane commented Feb 27, 2018

Ah, so fast! Thank you! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants