🔥Hotfix🔥 Release 5.1.1: Fix ACL issue

dbmdz · Oct 18, 2021 · 12768fa · 12768fa
1 parent 2121a35
commit 12768fa
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [5.1.1] - 2021-10-18
+### Fixed
+- Fixed ACL check in `ImageServiceImpl` that did not pass the HTTP request to the security backend
+
 ## [5.1.0] - 2021-10-15
 ### Added
 - New API in [`ImageSecurityService`][api-image] and [`PresentationSecurityService`][api-presentation]

diff --git a/pom.xml b/pom.xml
@@ -14,7 +14,7 @@
 
   <groupId>de.digitalcollections</groupId>
   <artifactId>iiif-server-hymir</artifactId>
-  <version>5.1.1-SNAPSHOT</version>
+  <version>5.1.1</version>
   <packaging>jar</packaging>
 
   <url>https://github.com/dbmdz/iiif-server-hymir</url>

diff --git a/src/main/java/de/digitalcollections/iiif/hymir/image/business/ImageServiceImpl.java b/src/main/java/de/digitalcollections/iiif/hymir/image/business/ImageServiceImpl.java
@@ -161,7 +161,8 @@ private void enrichInfo(
   /** Try to obtain a {@link ImageReader} for a given identifier */
   private ImageReader getReader(String identifier)
       throws ResourceNotFoundException, UnsupportedFormatException, IOException {
-    if (imageSecurityService != null && !imageSecurityService.isAccessAllowed(identifier, currentRequest)) {
+    if (imageSecurityService != null
+        && !imageSecurityService.isAccessAllowed(identifier, currentRequest)) {
       throw new ResourceNotFoundException();
     }
     FileResource fileResource;
@@ -429,7 +430,8 @@ public void processImage(
 
   @Override
   public Instant getImageModificationDate(String identifier) throws ResourceNotFoundException {
-    if (imageSecurityService != null && !imageSecurityService.isAccessAllowed(identifier)) {
+    if (imageSecurityService != null
+        && !imageSecurityService.isAccessAllowed(identifier, currentRequest)) {
       throw new ResourceNotFoundException();
     }
     try {