Upgrade Python 3.11 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netsettler
approved these changes
Sep 21, 2023
.github/workflows/main-publish.yml
Outdated
| # This workflow contains a single job called "build" | ||
| build: | ||
| # The type of runner that the job will run on | ||
| runs-on: ubuntu-20.04 |
.github/workflows/main-publish.yml
Outdated
| with: | ||
| python-version: 3.8 | ||
| - name: Install Python dependencies for publish | ||
| run: python -m pip install dcicutils==7.5.1 |
There was a problem hiding this comment.
This pinning is awkward. Is it right? Is there a way to centralize this better? Some reason pip install dciciutils without a version wouldn't work? I assume this same problem occurs in other repos.
There was a problem hiding this comment.
Make target that can be reproduced across all repos? I think the concern is somehow bringing in an earlier version that doesn't have the publish command.
pyproject.toml
Outdated
| boto3 = "^1.20.15" | ||
| python = ">=3.7,<3.12" | ||
| dcicutils = "7.12.0.1b1" | ||
| boto3 = "^1.28.51" |
There was a problem hiding this comment.
maybe add corresponding boto3-stubs?
netsettler
reviewed
Sep 21, 2023
pyproject.toml
Outdated
| python = ">=3.7,<3.9" | ||
| dcicutils = "^6.3.0" | ||
| boto3 = "^1.20.15" | ||
| python = ">=3.7,<3.12" |
willronchetti
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.