Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.8 #336

Closed
24 tasks done
mikealfare opened this issue Oct 21, 2024 · 1 comment
Closed
24 tasks done

Remove support for Python 3.8 #336

mikealfare opened this issue Oct 21, 2024 · 1 comment

Comments

@mikealfare
Copy link
Contributor

mikealfare commented Oct 21, 2024

Short description

Python 3.8 is officially EOL (as of 10-07-2024). We have already run into an issue where something broke on scheduled testing because a dependency no longer supports Python 3.8. Also, dbt-core has removed support for Python 3.8, both on main and for all older versions. We should update our CI workflows to no longer test against Python 3.8 and update our supported versions on PyPI to no longer list Python 3.8 (since we will not be testing against it).

PRs

  1. cla:yes
    mikealfare
  2. cla:yes
    mikealfare
  3. cla:yes
    mikealfare
  4. cla:yes
    mikealfare
  5. cla:yes
    mikealfare
  6. cla:yes
    mikealfare
  7. cla:yes
    mikealfare
  8. cla:yes
    mikealfare
  9. cla:yes
    mikealfare
  10. cla:yes
    mikealfare
  11. cla:yes
    mikealfare
  12. cla:yes
    mikealfare
  13. cla:yes
    mikealfare
  14. cla:yes
    mikealfare
  15. cla:yes
    mikealfare
  16. cla:yes
    mikealfare
  17. cla:yes
    mikealfare
  18. cla:yes
    mikealfare
  19. cla:yes
    mikealfare
  20. cla:yes
    mikealfare

Acceptance criteria

Testing

Security

N/A

Docs

We should remove Python 3.8 support from all of our docs. Updating this repo will remove it from places like PyPI or READMEs. But we might also list this on docs.getdbt.com.

Consequences

This effectively locks all feature development for 3.8 as newer patch versions on PyPI will not be available to pip. Adapters could implement new features themselves, but they would not be able to pick up new features from dbt-adapters, or a concrete adapter that they subclass (e.g. dbt-databricks uses dbt-spark). As 3.8 is EOL, this is considered low risk.

@mikealfare mikealfare added enhancement New feature or request refinement user docs tech_debt and removed enhancement New feature or request refinement labels Oct 21, 2024
@mikealfare mikealfare self-assigned this Oct 21, 2024
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#6333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants