Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing migration #102

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Fix testing migration #102

merged 3 commits into from
Feb 22, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Feb 22, 2024

Resolves dbt-labs/dbt-postgres#4

Problem

We were too aggressive when migrating test cases out of dbt-tests-adapter into dbt-postgres and made breaking changes. This arose in dbt-bigquery scheduled testing:
https://github.com/dbt-labs/dbt-bigquery/actions/runs/7995656484/job/21836461373#step:7:1811

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Feb 22, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare added the pre-regression Regression not yet in a stable release label Feb 22, 2024
@mikealfare mikealfare requested a review from a team February 22, 2024 15:34
@mikealfare mikealfare marked this pull request as ready for review February 22, 2024 17:56
@mikealfare mikealfare merged commit fef956f into main Feb 22, 2024
7 checks passed
@mikealfare mikealfare deleted the fix-testing-migration branch February 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-regression Regression not yet in a stable release Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement adapter tests in dbt-postgres
2 participants