Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ensure valid incremental strategy #331

Merged
merged 7 commits into from
Oct 18, 2024

Commits on Oct 16, 2024

  1. Add test to ensure a bad incremental strategy results in an error on run

    Right now, this test will fail. That is because the fix will be in the
    next commit. Presently if an incremental model is being built for the
    first time (because the relation in the data warehouse doesn't exist)
    or if the incremental model is being run as a full refresh, then validation
    that the incremental strategy _doesn't happen_. Technically for _most_
    incremental strategies, this is "okay" because the incremental strategy
    isn't used when creating the relation for the first time or during full
    refresh. The exception is the microbatch strategy, which is part of the
    problem. The other part of the problem is that this leads to an experience
    where if you write up an incremental model (with an invalid strategy) and
    then run it to ensure it works, you won't know anything is wrong until it
    is run for the second time.
    QMalcolm committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    037ef1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    608efdb View commit details
    Browse the repository at this point in the history
  3. Add changie doc

    QMalcolm committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cbc5b95 View commit details
    Browse the repository at this point in the history
  4. Fix lint

    QMalcolm committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2a1fef1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    96e7854 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7d9ea5 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    19cd1ef View commit details
    Browse the repository at this point in the history