Skip to content

Commit

Permalink
Revert "Add batch_id param to profile to pass along with `dataproc_…
Browse files Browse the repository at this point in the history
…v1.CreateBatchRequest` (#727)"

This reverts commit a42e13d.
  • Loading branch information
dataders authored Jul 13, 2023
1 parent d0d593e commit 331a8e6
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 11 deletions.
6 changes: 0 additions & 6 deletions .changes/unreleased/Features-20230517-092205.yaml

This file was deleted.

1 change: 0 additions & 1 deletion dbt/adapters/bigquery/connections.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ class BigQueryCredentials(Credentials):
dataproc_region: Optional[str] = None
dataproc_cluster_name: Optional[str] = None
gcs_bucket: Optional[str] = None
batch_id: Optional[str] = None

dataproc_batch: Optional[DataprocBatchConfig] = field(
metadata={
Expand Down
1 change: 0 additions & 1 deletion dbt/adapters/bigquery/python_submissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ def _submit_dataproc_job(self) -> dataproc_v1.types.jobs.Job:
request = dataproc_v1.CreateBatchRequest(
parent=parent,
batch=batch,
batch_id=self.credential.batch_id,
)
# make the request
operation = self.job_client.create_batch(request=request) # type: ignore
Expand Down
1 change: 0 additions & 1 deletion test.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ DBT_TEST_USER_3="serviceAccount:dbt-integration-test-user@dbt-test-env.iam.gserv
DATAPROC_REGION=us-
DATAPROC_CLUSTER_NAME=
GCS_BUCKET=
BATCH_ID=
2 changes: 0 additions & 2 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ def oauth_target():
"dataproc_region": os.getenv("DATAPROC_REGION"),
"dataproc_cluster_name": os.getenv("DATAPROC_CLUSTER_NAME"),
"gcs_bucket": os.getenv("GCS_BUCKET"),
"batch_id": os.getenv("BATCH_ID"),
}


Expand All @@ -54,5 +53,4 @@ def service_account_target():
"DATAPROC_CLUSTER_NAME"
), # only needed for cluster submission method
"gcs_bucket": os.getenv("GCS_BUCKET"),
"batch_id": os.getenv("BATCH_ID"),
}

0 comments on commit 331a8e6

Please sign in to comment.