Skip to content

Commit

Permalink
Recreate if allow_non_incremental_definition changed
Browse files Browse the repository at this point in the history
  • Loading branch information
bnaul committed Nov 10, 2023
1 parent b3e9eea commit 97332e6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
10 changes: 9 additions & 1 deletion dbt/adapters/bigquery/relation.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,16 @@ def materialized_view_config_changeset(
new_materialized_view = cls.materialized_view_from_model_node(runtime_config.model)

if new_materialized_view.options != existing_materialized_view.options:
# allow_non_incremental_definition cannot be changed via ALTER, must recreate
if (
new_materialized_view.options.allow_non_incremental_definition
== existing_materialized_view.options.allow_non_incremental_definition
):
action = RelationConfigChangeAction.alter
else:
action = RelationConfigChangeAction.create
config_change_collection.options = BigQueryOptionsConfigChange(
action=RelationConfigChangeAction.alter,
action=action,
context=new_materialized_view.options,
)

Expand Down
3 changes: 2 additions & 1 deletion dbt/adapters/bigquery/relation_configs/_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

from dbt.adapters.bigquery.relation_configs._base import BigQueryBaseRelationConfig
from dbt.adapters.bigquery.utility import bool_setting, float_setting, sql_escape
from dbt.adapters.relation_configs import RelationConfigChangeAction


@dataclass(frozen=True, eq=True, unsafe_hash=True)
Expand Down Expand Up @@ -160,4 +161,4 @@ class BigQueryOptionsConfigChange(RelationConfigChange):

@property
def requires_full_refresh(self) -> bool:
return False
return self.action != RelationConfigChangeAction.alter

0 comments on commit 97332e6

Please sign in to comment.