Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-696] [Pre-regression] batch_id needs to be a model config instead of in the profile #822

Closed
2 tasks done
dbeatty10 opened this issue Jul 12, 2023 · 0 comments · Fixed by #826
Closed
2 tasks done
Labels
bug Something isn't working pre-regression Regression not yet in a stable release

Comments

@dbeatty10
Copy link
Contributor

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

From @nickozilla here:

My initial implementation here: #727 does allow users to to set the batch_id for dataproc serverless models in the profile & this does apply onto a python model, but this wouldn't work for any projects that have more than one python model (which kinda defeats the point of including it at all). As the batch_id parameter needs to be unique, and this is not achievable via a profile level definition.

I've created this new implementation for declaring batch_id at the model level locally, which would be preferred.

#804 is intended to solve this.

Expected Behavior

The expectation and hope is that batch_id should be customizable for projects that have more than one python model.

Steps To Reproduce

See above.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-bigquery:

Additional Context

No response

@dbeatty10 dbeatty10 added bug Something isn't working triage pre-regression Regression not yet in a stable release labels Jul 12, 2023
@github-actions github-actions bot changed the title [Pre-regression] batch_id needs to be a model config instead of in the profile [ADAP-696] [Pre-regression] batch_id needs to be a model config instead of in the profile Jul 12, 2023
@dbeatty10 dbeatty10 removed the triage label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pre-regression Regression not yet in a stable release
Projects
None yet
1 participant