Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-942] [Feature] Remove copy materialization #965

Closed
3 tasks done
dbeatty10 opened this issue Oct 11, 2023 · 3 comments
Closed
3 tasks done

[ADAP-942] [Feature] Remove copy materialization #965

dbeatty10 opened this issue Oct 11, 2023 · 3 comments
Labels
enhancement New feature or request Stale triage

Comments

@dbeatty10
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-bigquery functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Per #820 (comment), add a deprecation warning for the copy materialization.

This is a follow-up to #964.

Optionally include upgrade instructions from here for those that rely upon this materialization.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@dbeatty10 dbeatty10 added enhancement New feature or request triage labels Oct 11, 2023
@github-actions github-actions bot changed the title [Feature] Remove copy materialization [ADAP-942] [Feature] Remove copy materialization Oct 11, 2023
@dbeatty10
Copy link
Contributor Author

In response to these options for replacement, @xemuliam raised the following:

Those two options will be working only if copy_table function won't be deleted from BigQuery adapter code

@xemuliam I see what you are saying about copy_table which in turn depends on copy_bq_table.

@dataders does this affect your thoughts on how best we can remove this materialization (or if we should)?

Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 9, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale triage
Projects
None yet
Development

No branches or pull requests

1 participant