Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging dbt source freshness command when loaded_at_field is omitted #1046

Closed

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Dec 6, 2023

resolves #1044

Problem

When loaded_at_field is omitted from a source, dbt source freshness has unexpected behavior. The command does not return. If loaded_at_field is provided and nothing else is changed, the command returns.

Solution

  • Provide a test case that addresses the issue
  • Raise a warning when loaded_at_field is missing
  • Skip the source when loaded_at_field is missing

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare removed their assignment Dec 13, 2023
@Fleid Fleid added bug Something isn't working regression labels Feb 15, 2024
@mikealfare mikealfare closed this Mar 2, 2024
@mikealfare mikealfare deleted the source-freshness/bug/missing-loaded-at-field branch April 25, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes regression
Projects
None yet
2 participants