Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.7.latest] Fix configuration change monitoring for scenarios with no changes (#1009) #1078

Merged
merged 1 commit into from
Jan 29, 2024
Merged

[Backport 1.7.latest] Fix configuration change monitoring for scenarios with no changes (#1009) #1078

merged 1 commit into from
Jan 29, 2024

Conversation

mikealfare
Copy link
Contributor

Backport 64e042a from #1009.

@mikealfare
ADAP-1017: Fix configuration change monitoring for scenarios with no …
a4a1732 
…changes (#1009)

* changie
* add a test demonstrating the issue
* check that the change collection has changes instead of checking that it exists
* remove the partition config value from the config change since it is not hashable

(cherry picked from commit 64e042a)
@mikealfare mikealfare self-assigned this Jan 29, 2024
@mikealfare mikealfare requested a review from a team as a code owner January 29, 2024 19:42
@cla-bot cla-bot bot added the cla:yes label Jan 29, 2024
@mikealfare mikealfare changed the title [backport 1.7.latest] Fix configuration change monitoring for scenarios with no changes (#1009) [Backport 1.7.latest] Fix configuration change monitoring for scenarios with no changes (#1009) Jan 29, 2024
@mikealfare mikealfare merged commit 374e403 into 1.7.latest Jan 29, 2024
36 checks passed
@mikealfare mikealfare deleted the backport/1.7.latest/1009 branch January 29, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @McKnight-42