Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow base64-service-account-json key auth Issue: #923 #1245

Conversation

rbaker1
Copy link
Contributor

@rbaker1 rbaker1 commented May 16, 2024

resolves #923

Problem

Currently, JSON key files can only be represented as a string. There is interest in being able to set the GCP service account as a base64 encoded string.

Solution

The user can input either a base54 represented JSON key file or a normal string. There is testing involved to ensure it is invoked correctly.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Copy link

cla-bot bot commented May 16, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @rbaker1

@rbaker1 rbaker1 changed the title added base64 functionality and basic testing Allow base64-service-account-json key auth Issue: #923 May 16, 2024
@cla-bot cla-bot bot added the cla:yes label May 16, 2024
@rbaker1 rbaker1 marked this pull request as ready for review May 16, 2024 20:21
@rbaker1 rbaker1 requested a review from a team as a code owner May 16, 2024 20:21
@jtcohen6 jtcohen6 added the user docs [docs.getdbt.com] Needs better documentation label May 31, 2024
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rbaker1! The change looks straightforward, especially with the tests you've added. I left one nit about method naming. Otherwise, this lgtm; I'd like an engineer from the team to review before we merge this in. I also added the user docs label because we'll need to open an issue for updating these docs on BQ connections.

dbt/adapters/bigquery/utility.py Outdated Show resolved Hide resolved
tests/functional/adapter/test_json_keyfile.py Show resolved Hide resolved
@rbaker1
Copy link
Contributor Author

rbaker1 commented Jun 1, 2024

Thanks for this @rbaker1! The change looks straightforward, especially with the tests you've added. I left one nit about method naming. Otherwise, this lgtm; I'd like an engineer from the team to review before we merge this in. I also added the user docs label because we'll need to open an issue for updating these docs on BQ connections.

It's my pleasure - should I make the doc update issue or will another member?

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs issue should be opened automatically when this PR is merged!

dbt/adapters/bigquery/utility.py Outdated Show resolved Hide resolved
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 5, 2024

fyi - I'm going to close and reopen the PR to re-trigger the expected tests

@jtcohen6 jtcohen6 closed this Jun 5, 2024
@jtcohen6 jtcohen6 reopened this Jun 5, 2024
@colin-rogers-dbt
Copy link
Contributor

@cla-bot check

@rbaker1
Copy link
Contributor Author

rbaker1 commented Jun 10, 2024

@cla-bot check

I signed off on the cla weeks ago :S

@colin-rogers-dbt
Copy link
Contributor

@cla-bot check

@colin-rogers-dbt
Copy link
Contributor

@cla-bot check

I signed off on the cla weeks ago :S

yea it's a little temperamental sometimes

@colin-rogers-dbt colin-rogers-dbt merged commit 526eefa into dbt-labs:main Jun 10, 2024
53 checks passed
@colin-rogers-dbt
Copy link
Contributor

Bypassing stuck cla-bot check

@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#5640

@colin-rogers-dbt colin-rogers-dbt added the community This PR is from a community member label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member ok to test user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-882] [Feature] Allow base64-service-account-json key auth
4 participants