Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport 1122 to 1.8.latest #1380

Merged
merged 2 commits into from
Oct 22, 2024
Merged

backport 1122 to 1.8.latest #1380

merged 2 commits into from
Oct 22, 2024
+46 −4

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Oct 21, 2024 •
edited
Loading

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@salimmoulouel @colin-rogers-dbt
implement choice of delimiter for seed files (#1122)
839944d 
* implement choice of delimiter for seed files

* adding change log entry

* implementation of test of TestBigQuerySeedWithUniqueDelimiter

* Update dbt/adapters/bigquery/impl.py

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

* Update dbt/include/bigquery/macros/materializations/seed.sql

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

* Update dbt/include/bigquery/macros/materializations/seed.sql

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

* Update dbt/adapters/bigquery/impl.py

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

* Update .changes/unreleased/Fixes-20240226-233024.yaml

---------

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
(cherry picked from commit 0d37ba6)
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner October 21, 2024 20:40
@cla-bot cla-bot bot added the cla:yes label Oct 21, 2024
@colin-rogers-dbt colin-rogers-dbt changed the base branch from main to 1.8.latest October 21, 2024 20:40
@colin-rogers-dbt colin-rogers-dbt self-assigned this Oct 21, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit 1ae695b into 1.8.latest Oct 22, 2024
48 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the backport-1122-to-1.8.latest branch October 22, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees

@colin-rogers-dbt colin-rogers-dbt

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @mikealfare @salimmoulouel