Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split part negative part number #616

Closed
wants to merge 4 commits into from

Conversation

dave-connors-3
Copy link
Contributor

resolves #615

Description

Adds part_number to the second calculation when argument is negative to return the correct element from the array.

Checklist

@cla-bot
Copy link

cla-bot bot commented Mar 19, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dave Connors.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@cla-bot
Copy link

cla-bot bot commented Mar 19, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dave Connors.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Mar 20, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dave Connors.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mikealfare
Copy link
Contributor

@dave-connors-3, you closed this PR, do you still need the branch?

@mikealfare mikealfare deleted the fix-split-part-negative-part-number branch August 2, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-384] [Bug] Negative part_number for dbt.split_part() is not working
2 participants