-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAP-394] support change monitoring for materialized views #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
McKnight-42
commented
Sep 12, 2023
McKnight-42
commented
Sep 12, 2023
McKnight-42
commented
Sep 12, 2023
mikealfare
reviewed
Sep 12, 2023
…com/dbt-labs/dbt-bigquery into feature/materialized-views/ADAP-394
…feature/materialized-views/ADAP-394
… to use new method
McKnight-42
commented
Sep 21, 2023
dbt/include/bigquery/macros/relations/materialized_view/describe.sql
Outdated
Show resolved
Hide resolved
…feature/materialized-views/ADAP-394
…feature/materialized-views/ADAP-394
…com/dbt-labs/dbt-bigquery into feature/materialized-views/ADAP-394
McKnight-42
commented
Sep 25, 2023
dbt/include/bigquery/macros/relations/materialized_view/describe.sql
Outdated
Show resolved
Hide resolved
…940' into feature/materialized-views/ADAP-940
* committing to park changes and wrap up other 1.7 items * update describe to use the sdk instead of sql to pick up partition information * basic tests pass * existing change monitoring tests pass * partition change monitoring tests pass --------- Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare
reviewed
Oct 11, 2023
mikealfare
reviewed
Oct 11, 2023
mikealfare
reviewed
Oct 11, 2023
mikealfare
reviewed
Oct 11, 2023
mikealfare
reviewed
Oct 11, 2023
mikealfare
reviewed
Oct 11, 2023
…ialized-views/ADAP-394 # Conflicts: # dbt/adapters/bigquery/impl.py # dbt/adapters/bigquery/relation.py # dbt/adapters/bigquery/relation_configs/_base.py # dbt/adapters/bigquery/relation_configs/_partition.py # dbt/include/bigquery/macros/relation_components/partition/describe.sql
…o perform all checks
colin-rogers-dbt
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#6911
docs dbt-labs/docs.getdbt.com/#
Problem
We need to be able to configure materialized views and apply configuration changes with as little impact/cost as possible.
Solution
Implement configuration options:
Implement change monitoring on all of these attributes and apply it via an alter statement where possible. This can generally be done when an attribute is set via
OPTIONS()
. This includes:Updating partitioning and clustering will require full refreshes.
Checklist