Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-394] support change monitoring for materialized views #914

Merged
merged 73 commits into from
Oct 11, 2023

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Sep 7, 2023

resolves dbt-labs/dbt-core#6911
docs dbt-labs/docs.getdbt.com/#

Problem

We need to be able to configure materialized views and apply configuration changes with as little impact/cost as possible.

Solution

Implement configuration options:

  • automatic refresh
  • clustering
  • partitioning
  • expiration
  • kms key
  • labels
  • description

Implement change monitoring on all of these attributes and apply it via an alter statement where possible. This can generally be done when an attribute is set via OPTIONS(). This includes:

  • automatic refresh
  • expiration
  • kms key
  • labels
  • description

Updating partitioning and clustering will require full refreshes.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Sep 7, 2023
@cla-bot cla-bot bot added the cla:yes label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

dbt/adapters/bigquery/impl.py Outdated Show resolved Hide resolved
dbt/adapters/bigquery/relation.py Outdated Show resolved Hide resolved
dbt/adapters/bigquery/relation_configs/base.py Outdated Show resolved Hide resolved
@mikealfare mikealfare marked this pull request as ready for review October 10, 2023 05:27
@mikealfare mikealfare requested a review from a team as a code owner October 10, 2023 05:27
mikealfare and others added 4 commits October 11, 2023 15:47
…ialized-views/ADAP-394

# Conflicts:
#	dbt/adapters/bigquery/impl.py
#	dbt/adapters/bigquery/relation.py
#	dbt/adapters/bigquery/relation_configs/_base.py
#	dbt/adapters/bigquery/relation_configs/_partition.py
#	dbt/include/bigquery/macros/relation_components/partition/describe.sql
@mikealfare mikealfare merged commit e72cc51 into main Oct 11, 2023
23 checks passed
@mikealfare mikealfare deleted the feature/materialized-views/ADAP-394 branch October 11, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2068] [Feature] Let's add Materialized View as a materialization, finally
3 participants