Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address type annotation issues and clean up impl #933

Merged
merged 10 commits into from
Sep 22, 2023
Merged

Address type annotation issues and clean up impl #933

merged 10 commits into from
Sep 22, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Sep 21, 2023 •
edited by dbeatty10
Loading

resolves #934
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner September 21, 2023 22:55
@cla-bot cla-bot bot added the cla:yes label Sep 21, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

colin-rogers-dbt
colin-rogers-dbt commented Sep 21, 2023
View reviewed changes
dbt/adapters/bigquery/impl.py
all_datasets = client.list_datasets(project=database, max_results=10000)
return [ds.dataset_id for ds in all_datasets]

return self.connections._retry_and_handle(msg="list dataset", conn=conn, fn=query_schemas)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should never be referencing a private ConnectionManager method in impl

@colin-rogers-dbt colin-rogers-dbt changed the title Address Type Annotation Issues and remove protected method ref from impl Address type annotation issues and clean up impl Sep 22, 2023
@colin-rogers-dbt colin-rogers-dbt merged commit 9f6c449 into main Sep 22, 2023
25 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the fixTypeAnnotations branch September 22, 2023 18:24
@dbeatty10 dbeatty10 mentioned this pull request Sep 24, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may nathaniel-may is a code owner automatically assigned from dbt-labs/adapters

@mikealfare mikealfare Awaiting requested review from mikealfare

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-909] Fix mypy Failure
3 participants
@colin-rogers-dbt @McKnight-42 @peterallenwebb